ct: triage all currently remaining TODO(ct)s in adapter #29917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numbers correspond to which [milestone] that they need to be fixed by. [milestone]: https://github.com/MaterializeInc/database-issues/issues/8427
danhhz
commented
Oct 9, 2024
| @@ -42,7 +42,6 @@ use crate::optimize::{self, Optimize, OptimizerCatalog}; | |||
| use crate::session::Session; | |||
| use crate::util::ResultExt; | |||
|
|
|||
| // TODO(ct): Big oof. Dedup a bunch of this with MVs. | |||
There was a problem hiding this comment.
After factoring bits of it out to share internally, feels like there is less to do here.
| @@ -1414,7 +1414,6 @@ pub struct CreateContinualTaskStatement<T: AstInfo> { | |||
| pub enum ContinualTaskStmt<T: AstInfo> { | |||
| Delete(DeleteStatement<T>), | |||
| Insert(InsertStatement<T>), | |||
| // TODO(ct): Update/upsert? | |||
There was a problem hiding this comment.
Doesn't feel actionable IMO. I mostly left this in here in first place without thinking because when I type an enum with Delete and Insert variants, I naturally consider Update/Upsert. Notably, none of the initial use cases in my doc seemed to need them
| @@ -735,10 +735,8 @@ pub struct CreateContinualTaskPlan { | |||
| // `continual_task.expr`. None on restart. | |||
| pub placeholder_id: Option<mz_expr::LocalId>, | |||
| pub desc: RelationDesc, | |||
| // TODO(ct): Multiple inputs. | |||
There was a problem hiding this comment.
Duplicate of the one in parser.rs
| pub input_id: GlobalId, | ||
| pub continual_task: MaterializedView, | ||
| // TODO(ct): replace, drop_ids, if_not_exists |
There was a problem hiding this comment.
Duplicate of the one in parser.rs
ParkMyCar
approved these changes
Oct 9, 2024
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numbers correspond to which milestone that they need to be fixed by.
Touches MaterializeInc/database-issues#8427
Motivation
Tips for reviewer
The priority here is finding if there are any M1 items left, would love a second set of eyes on this in particular. Some of the M2 vs M3 decisions feel like they could go either way, definitely open to feedback.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.