adapter: Reduce a warn! to an info!
#29641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause backtrace takes a long time
jkosh44
reviewed
Sep 18, 2024
Comment on lines
+712
to
+715
| // Note: it's possible that the secret can be dropped before we have | ||
| // a chance to cleanup the replication slot. This is somewhat expected | ||
| // so emit a log but there's no reason to have an error. | ||
| tracing::info!( |
There was a problem hiding this comment.
Is there any way to keep it as a warn but remove the stack trace? warn feels a bit more appropriate because it's unexpected.
def-
changed the title
warn! to an info!warn! to an info!
I'm not sure! I just noticed the large backtrace in that one case, normally I don't remember seeing backtraces for warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces a
warn!to aninfo!because previously we've seen getting the backtrace after the warn take a significant amount of time and this scenario is somewhat expected.Motivation
Fixes https://github.com/MaterializeInc/database-issues/issues/8301
The ability for this PR to fix that linked issue is predicated on the idea that for
warn!s we automatically get a backtrace, which is something I'm not sure about. @def- do you know?Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.