sql-parser: align SUBSCRIBE syntax with CREATE SINK/SELECT #29356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "output options" for
SUBSCRIBE
(i.e., theENVELOPE
andWITHIN TIMESTAMP ORDER BY
clauses) were jammed in at the end of the statement, as in:This was inconsistent with our other SQL statements. In particular, CREATE SOURCE and CREATE SINK always put the WITH options at the very end of the statement:
And SELECT always puts the AS OF clause at the very end of the statement:
This commit restores the consistency that used to be present in
SUBSCRIBE
by moving the output options to before theAS OF
,UP TO
, andWITH
options:The old syntax remains supported for backwards compatibility, but is softly deprecated. Only the new syntax will be mentioned in the docs going forward.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.