Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: slim down build scripts #29246

Merged

Conversation

ParkMyCar
Copy link
Member

Previously I had thought build scripts could reference dependencies in the [dependencies] section of Cargo, but this is incorrect (docs)! This PR removes regular dependencies from build scripts which tidies things up a bit and should make the build faster.

Motivation

https://github.com/MaterializeInc/database-issues/issues/7923

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

* build scripts cannot depend on normal dependencies or dev-dependencies, so don't include them
@ParkMyCar ParkMyCar requested review from aljoscha, danhhz, jkosh44, a team and teskje as code owners August 27, 2024 19:48
@ParkMyCar
Copy link
Member Author

After this change the number of total build actions goes from 4,259 to 3,878! Because of remote caching there won't be too much of a speed up, but definitely will help in some cases

@ParkMyCar ParkMyCar merged commit 263b776 into MaterializeInc:main Aug 27, 2024
82 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
@ParkMyCar ParkMyCar deleted the bazel/slim-down-buildscripts branch January 13, 2025 00:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants