[WIP] adapter,controller: mz_cluster_replica_metrics source #29238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit converts `mz_cluster_replica_metrics` from a "retained metrics" builtin table to an append-only builtin source. The coordinator no longer needs to be involved in writing metrics data to storage, this can now happen in the controller. This commit does not include any code to partially truncate `mz_cluster_replica_metrics`, which is something we want to ensure it doesn't grow unboundedly. A subsequent commit will deal with that.
This commit removes support for background table updates, as it is now unused. This simplifies the code a bit.
This commit adapts the tests to the changes made to the `mz_cluster_replica_metrics` system relation: * It's no longer a table but a source. * It has an extra column with the event time. * It is a log rather than a snapshot of the most recent state. The `statement-logging` cluster test runs into #29237 when querying the new `mz_cluster_replica_metrics` source, so that query has been disabled until the bug is fixed.
teskje
force-pushed
the
mz_cluster_replica_metrics-log
branch
from
351982c to
9f5827c
Compare
|
Closing in favor of #29254. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
mz_cluster_replica_metricsfrom a "retained metrics" builtin table to an append-only builtin source. The coordinator no longer needs to be involved in writing metrics data to storage, this happens now in the controller.TODO
Motivation
Part of https://github.com/MaterializeInc/database-issues/issues/8403
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.