Feature/graceful reconfig until ready sql #28821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
2 times, most recently
from
4639d4c to
5b7528d
Compare
5 tasks
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
5 times, most recently
from
a91cb8a to
35e8a48
Compare
jubrad
changed the title
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
from
35e8a48 to
843d31c
Compare
jkosh44
approved these changes
Aug 16, 2024
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
2 times, most recently
from
cb5a83c to
ead5646
Compare
benesch
approved these changes
Aug 16, 2024
src/sql/src/plan/error.rs
Outdated
| @@ -739,6 +740,9 @@ impl fmt::Display for PlanError { | |||
| }, | |||
| Self::SubsourceResolutionError(e) => write!(f, "{}", e), | |||
| Self::Replan(msg) => write!(f, "internal error while replanning, please contact support: {msg}"), | |||
| Self::UntilReadyTimeoutRequired => { | |||
| write!(f, "TIMEOUT=<duration> option is required for ALTER CLUSTER ... WITH ( WAIT UNTIL READY ( ... ) )") | |||
There was a problem hiding this comment.
Suggested change
| write!(f, "TIMEOUT=<duration> option is required for ALTER CLUSTER ... WITH ( WAIT UNTIL READY ( ... ) )") | |
| write!(f, "TIMEOUT=<duration> option is required for ALTER CLUSTER ... WITH (WAIT UNTIL READY ( ... ))") |
src/sql/src/plan/statement/ddl.rs
Outdated
| @@ -4894,6 +4901,9 @@ pub fn plan_alter_cluster( | |||
| &crate::session::vars::ENABLE_GRACEFUL_CLUSTER_RECONFIGURATION, | |||
| )?; | |||
| } | |||
| AlterClusterPlanStrategy::UntilReady { .. } => { | |||
| bail_unsupported!("ALTER CLUSTER .. WITH ( WAIT UNTIL READY...) is not yet implemented"); | |||
There was a problem hiding this comment.
Suggested change
| bail_unsupported!("ALTER CLUSTER .. WITH ( WAIT UNTIL READY...) is not yet implemented"); | |
| bail_unsupported!("ALTER CLUSTER .. WITH (WAIT UNTIL READY...) is not yet implemented"); |
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
from
ead5646 to
fff87dd
Compare
morsapaes
approved these changes
Aug 16, 2024
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
from
fff87dd to
1594d23
Compare
add ddl for wait until ready, keeps feature disabled/unimplemented.
jubrad
force-pushed
the
feature/graceful-reconfig-until-caught-up-sql
branch
from
1594d23 to
ed90d44
Compare
benesch
approved these changes
Aug 18, 2024
morsapaes
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
Thanks, @jubrad! Linking to the SQL Council thread for posterity.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds SQL parsing for
ALTER CLUSTER ... WITH ( WAIT UNTIL READY=(<options>) )where options are
TIMEOUT=<duration>andON TIMEOUT=<COMMIT|ROLLBACK>https://github.com/MaterializeInc/database-issues/issues/5976
This PR is stacked on the following PRs
This was formerly known as
until caught upbut the language has been changed tountil readyfor both clarity and to allow us to shift the definition of "ready" internally for this feature without needing to add new sql changes.Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.