persist: followups from #24867 #24895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing the code review comments from MaterializeInc#24867 as a followup so we could sneak that one into this week's release.
5 tasks
bkirwi
approved these changes
Feb 1, 2024
danhhz
commented
Feb 1, 2024
| .await | ||
| .ok_or(blob_key)?; | ||
| .await; | ||
| let value = value.unwrap_or_else(|| { |
There was a problem hiding this comment.
Ah right, compaction is why we didn't have this here. I suppose we can still make compaction work because it fetches things in tasks, which catches the panic and turns it into an Err, but that doesn't feel great...
|
Cleaning up old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the code review comments from #24867 as a followup so we could sneak that one into this week's release.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.