Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog: Remove usages of term Stash #23532

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Nov 29, 2023

This commit removes usages of the term Stash from comments, logs, strings, and variable names and replaces it with something more generic like "catalog" or "catalog storage". We are working on replacing the Stash as the backing durable store for the catalog with persist, which will make these usages inaccurate.

Works towards resolving MaterializeInc/database-issues#6762

Motivation

This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • There are no user-facing behavior changes.

This commit removes usages of the term Stash from comments, logs,
strings, and variable names and replaces it with something more generic
like "catalog" or "catalog storage". We are working on replacing the
Stash as the backing durable store for the catalog with persist, which
will make these usages inaccurate.

Works towards resolving #22392
@jkosh44 jkosh44 marked this pull request as ready for review November 29, 2023 14:50
@jkosh44 jkosh44 requested review from a team as code owners November 29, 2023 14:50
@jkosh44 jkosh44 requested review from a team and maddyblue November 29, 2023 14:51
@jkosh44 jkosh44 enabled auto-merge (squash) November 29, 2023 15:16
@jkosh44 jkosh44 merged commit 893be8e into MaterializeInc:main Nov 29, 2023
2 checks passed
@jkosh44 jkosh44 deleted the stash-catalog-cleanup branch November 29, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants