Skip to content

Commit

Permalink
adapter: upgrade parameter sync logging to INFO
Browse files Browse the repository at this point in the history
This allows us to discover which configs were active on a given
environment at a given time when debugging a past incident. The volume
of these log lines should be pretty low given that we don't update LD
flags all the time.
  • Loading branch information
teskje committed Nov 20, 2023
1 parent 1b7afa7 commit 2aac976
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/adapter/src/catalog/open.rs
Original file line number Diff line number Diff line change
@@ -1155,13 +1155,13 @@ impl Catalog {
.map(|param| {
let name = param.name;
let value = param.value;
tracing::debug!(name, value, "sync parameter");
tracing::info!(name, value, initial = true, "sync parameter");
(name, OwnedVarInput::Flat(value))
})
.chain(std::iter::once({
let name = CONFIG_HAS_SYNCED_ONCE.name().to_string();
let value = true.to_string();
tracing::debug!(name, value, "sync parameter");
tracing::info!(name, value, initial = true, "sync parameter");
(name, OwnedVarInput::Flat(value))
}))
.collect::<Vec<_>>();
4 changes: 2 additions & 2 deletions src/adapter/src/config/backend.rs
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
use std::collections::BTreeMap;

use mz_sql::session::user::SYSTEM_USER;
use tracing::{debug, error};
use tracing::{error, info};

use crate::config::SynchronizedParameters;
use crate::{AdapterError, Client, SessionClient};
@@ -40,7 +40,7 @@ impl SystemParameterBackend {
vars.insert(param.name.clone(), param.value.clone());
match self.session_client.set_system_vars(vars).await {
Ok(()) => {
debug!(name = param.name, value = param.value, "sync parameter");
info!(name = param.name, value = param.value, "sync parameter");
}
Err(error) => {
error!(

0 comments on commit 2aac976

Please sign in to comment.