Fixes for #637 - ls2string does not append to the package list #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for MariaDB@c270d1a where the condition has been reversed.
RazvanLiviuVarzaru
force-pushed
the
fix/ls2string
branch
2 times, most recently
from
8068eb4 to
723f85a
Compare
The function is used only for checking that packages were generated for both RPM and DEB. Returns True if "packages" property is not empty. If the packages are generated, several further actions can take place: -> publish the packages on CI -> trigger Install / Upgrade builders which in turn install the packages from CI
RazvanLiviuVarzaru
force-pushed
the
fix/ls2string
branch
from
723f85a to
29b3e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is mainly a fix for #637 and a renaming suggestion for the
hasFilesfunction to better highlight its purpose.