MDBF-815 - HashiCorp Vault server #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazvanLiviuVarzaru
force-pushed
the
feature/MDBF-815
branch
2 times, most recently
from
da35016 to
e80dad8
Compare
fauust
requested changes
Dec 20, 2024
ci_build_images/hashicorp.Dockerfile
Outdated
|
|
||
| RUN curl -fsSL https://apt.releases.hashicorp.com/gpg | gpg --dearmor -o /usr/share/keyrings/hashicorp-archive-keyring.gpg \ | ||
| && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/hashicorp-archive-keyring.gpg] \ | ||
| https://apt.releases.hashicorp.com $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/hashicorp.list \ |
There was a problem hiding this comment.
lsb_release is fragile and needs the command to be installed, use /etc/os-release instead. See other example in the repo.
Indentation could be improved:
RUN ...
&& ...
&&
There was a problem hiding this comment.
@fauust apt.releases.hashicorp.com requires the codename .
I'm only using this for Debian/Ubuntu.
/etc/os-release won't provide the codename without further string processing, which I really don't like.
The scope of this PR is to create a separate Debian 12/i386 container image
with HashiCorp Vault installed.
Vault tests are part of the MBDF-815 requirements,
and the new fulltest-debug builder will use this image.
Changes to the BuildBot configuration will be done in a separate PR.
Built the image locally and tested on:
Server version: 10.11.11
Revision: c391fb1ff122adbfb9a7f98d3239aa08311918d6
# Create Debug build
cmake . -DCMAKE_BUILD_TYPE=Debug -DWITH_EMBEDDED_SERVER=1 \
-DHAVE_EMBEDDED_PRIVILEGE_CONTROL=1 -DWITH_DBUG_TRACE=OFF && make -j 24
# Start Vault server
vault server -dev > /dev/null 2>&1 &
# Run MTR with --suite=vault
cd mysql-test && perl mysql-test-run.pl --suite=vault \
--parallel=1 --verbose-restart --force --big
==============================================================================
TEST RESULT TIME (ms) or COMMENT
--------------------------------------------------------------------------
worker[01] Using MTR_BUILD_THREAD 300, with reserved ports 19000..19029
vault.hashicorp_mariabackup [ pass ] 3013
vault.hashicorp_cache_after_recreate [ pass ] 3232
vault.hashicorp_key_rotation_age [ pass ] 15220
vault.hashicorp_check_kv_version [ pass ] 4679
vault.hashicorp_encode [ pass ] 451
vault.hashicorp_key_migration [ pass ] 5881
vault.hashicorp_url_prefix [ pass ] 4735
vault.hashicorp_cache_timeout_update [ pass ] 402
--------------------------------------------------------------------------
The servers were restarted 4 times
Spent 37.613 of 43 seconds executing testcases
Completed: All 8 tests were successful.
RazvanLiviuVarzaru
force-pushed
the
feature/MDBF-815
branch
from
a6429bb to
8d0be50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scope of this PR is to create a separate
Debian 12/i386container image withHashiCorp Vaultinstalled.Vault tests are part of the MBDF-815 requirements, and the new
fulltest-debugbuilder will use this image.Changes to the BuildBot configuration will be done in a separate PR.
Testing
Built the image locally and tested on:
Create Debug build
Start Vault server
vault server -dev > /dev/null 2>&1 &Run MTR with --suite=vault
cd mysql-test && perl mysql-test-run.pl --suite=vault --parallel=1 --verbose-restart --force --big