Skip to content

Commit

Permalink
Refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
Marc Littlemore committed Jul 20, 2017
1 parent 7f10f84 commit 835f0be
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/AmazonAPI.php
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private function AddError($error) {
array_push($this->mErrors, $error);
}

private function MakeSignedRequest($params) {
private function MakeAndParseRequest($params) {
$signedUrl = $this->urlBuilder->generate($params);

try {
Expand All @@ -141,13 +141,8 @@ private function MakeSignedRequest($params) {
$this->AddError("Error downloading data : $signedUrl : " . $error->getMessage());
}

return false;
}

private function MakeAndParseRequest($params) {
$parsedXml = $this->MakeSignedRequest($params);
if ($parsedXml === false) {
return(false);
return false;
}

return $this->dataTransformer->execute($parsedXml);
Expand Down

0 comments on commit 835f0be

Please sign in to comment.