Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): use env var for base path url #34

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

pfongkye
Copy link
Contributor

Use env var to define base path URL to give flexibility in defining API.

@pfongkye pfongkye requested review from greg0ire and cicoub13 July 18, 2024 16:02
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.63%. Comparing base (f1a9884) to head (7ede25e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   75.62%   75.63%   +0.01%     
==========================================
  Files          93       93              
  Lines        1883     1884       +1     
  Branches      366      365       -1     
==========================================
+ Hits         1424     1425       +1     
  Misses        429      429              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@greg0ire greg0ire merged commit de5ee01 into ManoManoTech:main Jul 19, 2024
3 checks passed
@greg0ire
Copy link
Member

Thanks! Squashed!

@pfongkye pfongkye deleted the chore/api-path branch July 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants