Skip to content

Commit

Permalink
Merge pull request #35 from ManoManoTech/chore-node-20
Browse files Browse the repository at this point in the history
chore(node): Update to node 20
  • Loading branch information
cicoub13 authored Aug 5, 2024
2 parents de5ee01 + f5e43a8 commit 793053d
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20
- run: yarn install --frozen-lockfile
- run: yarn build
- run: yarn lint
- run: yarn test --coverage

- name: "Upload to Codecov"
uses: "codecov/codecov-action@v4"
- name: 'Upload to Codecov'
uses: 'codecov/codecov-action@v4'
with:
directory: coverage
env:
CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
CODECOV_TOKEN: '${{ secrets.CODECOV_TOKEN }}'
2 changes: 1 addition & 1 deletion .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
- run: yarn install
- run: yarn build
- name: Upload build artifact
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v20
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18
FROM node:20

RUN mkdir -p /home/node/app \
&& chown -R node:node /home/node/app
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Slack organisation.
Be sure to have all those installed:

- [Docker Compose](https://docs.docker.com/compose/install/).
- [Node.js@18](https://nodejs.org/en/). You can use a version manager like
- [Node.js@20](https://nodejs.org/en/). You can use a version manager like
[nvm](https://github.com/nvm-sh/nvm).
- [Yarn@1](https://classic.yarnpkg.com/lang/en/).

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"test": "jest --runInBand --forceExit"
},
"engines": {
"node": ">=18"
"node": ">=20"
},
"dependencies": {
"@slack/web-api": "6.8.1",
Expand Down

0 comments on commit 793053d

Please sign in to comment.