Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine pep8speaks #4877

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Refine pep8speaks #4877

merged 1 commit into from
Jan 6, 2025

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Jan 1, 2025

Follow up to #4858. Ignores W503, which still shows up (see #4874) and is not recommended in PEP8 (Should a Line Break Before or After a Binary Operator?).


📚 Documentation preview 📚: https://mdanalysis--4877.org.readthedocs.build/en/4877/

@RMeli RMeli requested review from orbeckst and marinegor January 1, 2025 14:30
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (b8fe34b) to head (d89ac73).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4877      +/-   ##
===========================================
- Coverage    93.66%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21787    22853    +1066     
  Branches      3067     3067              
===========================================
+ Hits         20406    21399     +993     
- Misses         929     1002      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Knuth's style!

@orbeckst orbeckst self-assigned this Jan 6, 2025
@orbeckst orbeckst merged commit 59e478d into MDAnalysis:develop Jan 6, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants