Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Tests and various folders in MDAnalysis tests #4857

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 22, 2024

Format MDanalysis/tests and folders in MDAnalysisTests without any corresponding module in the package.


📚 Documentation preview 📚: https://mdanalysis--4857.org.readthedocs.build/en/4857/

@pep8speaks
Copy link

pep8speaks commented Dec 22, 2024

Hello @RMeli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 239:80: E501 line too long (259 > 79 characters)
Line 243:80: E501 line too long (505 > 79 characters)
Line 399:5: W503 line break before binary operator
Line 582:13: W503 line break before binary operator
Line 583:13: W503 line break before binary operator

Comment last updated at 2024-12-24 11:42:35 UTC

@RMeli
Copy link
Member Author

RMeli commented Dec 22, 2024

Nothing fishy on this one as far as I can tell. Good to go IMO.

@RMeli RMeli requested a review from marinegor December 22, 2024 12:40
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (9312fa6) to head (f4cf669).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4857      +/-   ##
===========================================
- Coverage    93.65%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21779    22845    +1066     
  Branches      3064     3064              
===========================================
+ Hits         20398    21391     +993     
- Misses         929     1002      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blanket LGTM — please merge when you're happy with it @RMeli

🎄 🎁

@RMeli RMeli merged commit 29deccc into MDAnalysis:develop Dec 24, 2024
23 of 24 checks passed
@RMeli RMeli deleted the fmt-tests branch December 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants