cdl: Better handling for missing settings #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI CrashDiagnosticLayer build queued with queue ID 339686. |
jeremyg-lunarg
force-pushed
the
jeremyg-empty-settings
branch
from
8be4dd2 to
c026307
Compare
|
CI CrashDiagnosticLayer build queued with queue ID 339693. |
|
CI CrashDiagnosticLayer build # 362 running. |
|
CI CrashDiagnosticLayer build # 362 passed. |
|
Would it be possible to delay the pre-init messages or load earlier the layer settings library ? |
|
Meanwhile this seems a better output but not ideal. |
christophe-lunarg
approved these changes
Jan 18, 2025
Distinguish between unset settings and those set to an empty string. This mostly affects message_severity, so that an empty string can turn all messages off. However there's a few messages that have to come out before the layer settings are read and those can't really be turned off.
jeremyg-lunarg
force-pushed
the
jeremyg-empty-settings
branch
from
c026307 to
5a92513
Compare
|
CI CrashDiagnosticLayer build queued with queue ID 351202. |
|
CI CrashDiagnosticLayer build # 369 running. |
|
CI CrashDiagnosticLayer build # 369 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distinguish between unset settings and those set to an empty string. This mostly affects message_severity, so that an empty string can turn all messages off. However there's a few messages that have to come out before the layer settings are read and those can't really be turned off.