Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffmpeg): apply upstream patches to fix VAAPI leaks and crashes #369

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

cgutman
Copy link
Contributor

@cgutman cgutman commented Oct 19, 2024

Description

These patches are necessary to address the regression reported in LizardByte/Sunshine#3268. It is typically just a leak, but it can become a crash in cases where we call eglTerminate() but the leaked VAAPI surfaces keep references to the DRI driver alive. On the next attempt to use EGL, it ends up invoking functions in a module that has been unloaded.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@cgutman cgutman changed the title fix(ffmpeg): apply upstream patches to fix VAAPI leaks fix(ffmpeg): apply upstream patches to fix VAAPI leaks and crashes Oct 19, 2024
@cgutman cgutman merged commit 0170afd into LizardByte:master Oct 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant