Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate certificates with unique serial numbers #645

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Dec 28, 2022

Description

Firefox doesn't like duplicate certificates with the same serial number. Additional certificates encountered will result in SEC_ERROR_REUSED_ISSUER_AND_SERIAL. We can easily avoid this by generating a unique serial number in our certificates.

Screenshot

Issues Fixed or Closed

Fixes #114

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Fixes SEC_ERROR_REUSED_ISSUER_AND_SERIAL using Firefox
@ReenigneArcher ReenigneArcher merged commit a996902 into LizardByte:nightly Dec 28, 2022
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants