Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch files to add and remove firewall rules #321

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Add batch files to add and remove firewall rules #321

merged 4 commits into from
Aug 17, 2022

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 10, 2022

I'm very sorry for the inconvenience. I keep on forgetting this PR and keep on deleting my fork.

Description

This change adds batch files to programmatically add and remove sunshine firewall rules. In my use case, if I run sunshinevc without opening Sunshine for the first time, Sunshine will silently fail and would not be discoverable within the network, as normally, you would have to deal with this popup first which sunshinevc wouldn't show:
image

Screenshot

It works as intended (admin required, of course):
image
image

Issues Fixed or Closed

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@github-actions
Copy link

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@github-actions github-actions bot changed the base branch from master to nightly August 10, 2022 13:23
@ReenigneArcher
Copy link
Member

ReenigneArcher commented Aug 10, 2022

I will take care of these in #330

Todo:

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these files to src_assets/windows/misc/firewall/ ? As well as update the branch please?

@sitiom
Copy link
Contributor Author

sitiom commented Aug 16, 2022

Can you move these files to src_assets/windows/misc/firewall/ ? As well as update the branch please?

Done.

@ReenigneArcher ReenigneArcher merged commit 53bd9ea into LizardByte:nightly Aug 17, 2022
@sitiom sitiom deleted the firewall-rules branch August 18, 2022 01:54
@ReenigneArcher ReenigneArcher mentioned this pull request Sep 12, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Installer should automatically add and remove firewall rules
2 participants