Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make version update check more robust #2437

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

  • Use BUILD_VERSION for flatpak, Portfile, and homebrew builds
  • Use version with v prefix for all builds
  • More robust version comparison in web ui

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix-make-version-update-check-more-robust branch from 9ad6821 to 857dd90 Compare April 18, 2024 02:37
@ReenigneArcher ReenigneArcher force-pushed the fix-make-version-update-check-more-robust branch from 857dd90 to b681aef Compare April 18, 2024 02:40
@ReenigneArcher ReenigneArcher added this to the v0.23.1 milestone Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.77%. Comparing base (c896dab) to head (b681aef).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2437    +/-   ##
========================================
  Coverage     6.77%   6.77%            
========================================
  Files           86      86            
  Lines        17523   17523            
  Branches      8070    8056    -14     
========================================
  Hits          1187    1187            
+ Misses       15392   14662   -730     
- Partials       944    1674   +730     
Flag Coverage Δ
Linux 5.75% <ø> (ø)
Windows 2.04% <ø> (ø)
macOS-12 8.44% <ø> (ø)
macOS-13 7.77% <ø> (-0.02%) ⬇️
macOS-14 8.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 69191ca into nightly Apr 18, 2024
53 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-make-version-update-check-more-robust branch April 18, 2024 19:35
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web interface claims there is a new version, while running latest available
1 participant