Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus PIN input on Web UI pin page #2384

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Apr 7, 2024

Description

This makes it faster to input the PIN after clicking on the PIN notification on the desktop, since you no longer need to click the PIN input or focus on it by pressing Tab many times.

Screenshot

image

Issues Fixed or Closed

N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2024

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher ReenigneArcher force-pushed the web-ui-pin-autofocus branch 2 times, most recently from 31aae01 to 92fbfd3 Compare April 12, 2024 00:50
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.10%. Comparing base (8eead65) to head (8bca553).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2384    +/-   ##
========================================
  Coverage     6.10%   6.10%            
========================================
  Files           86      86            
  Lines        17523   17523            
  Branches      8169    8169            
========================================
  Hits          1070    1070            
+ Misses       15413   15032   -381     
- Partials      1040    1421   +381     
Flag Coverage Δ
Linux 4.26% <ø> (ø)
Windows 2.04% <ø> (ø)
macOS-12 8.44% <ø> (-0.14%) ⬇️
macOS-13 7.78% <ø> (ø)
macOS-14 8.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@cgutman cgutman added this to the v0.23.1 milestone Apr 12, 2024
@cgutman cgutman force-pushed the web-ui-pin-autofocus branch from 92fbfd3 to 5c94acc Compare April 14, 2024 00:59
This makes it faster to input the PIN after clicking on the PIN
notification on the desktop, since you no longer need to click
the PIN input or focus on it by pressing Tab many times.
@cgutman cgutman force-pushed the web-ui-pin-autofocus branch from 5c94acc to 8bca553 Compare April 20, 2024 18:23
@cgutman cgutman merged commit dc22e24 into LizardByte:nightly Apr 20, 2024
53 checks passed
@Calinou Calinou deleted the web-ui-pin-autofocus branch April 20, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants