Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.14.0 windows package issues #197

Closed
sitiom opened this issue Jun 16, 2022 · 3 comments · Fixed by #332
Closed

v0.14.0 windows package issues #197

sitiom opened this issue Jun 16, 2022 · 3 comments · Fixed by #332
Labels
fixed This issue has been fixed and will be available in the next release. os:Windows OS is Windows

Comments

@sitiom
Copy link
Contributor

sitiom commented Jun 16, 2022 •
edited
Loading

Describe the Bug

In https://github.com/SunshineStream/Sunshine/releases/tag/v0.14.0, install-service.bat and uninstall-service.bat is removed.

Expected Behavior

install-service.bat and uninstall-service.bat should exist

Windows Installer should automatically install the sunshinevc service

Additional Context

https://github.com/SunshineStream/Sunshine/discussions/196

Sunshine Host Operating System and Version

Windows 11

Architecture

64 bit

Sunshine Version

0.14.0

GPU Type

Nvidia

GPU Model

GeForce RTX 2070 SUPER

GPU Driver/Mesa Version

512.95

Capture Method (Linux Only)

No response
@ReenigneArcher
Copy link
Member

Update tools component to include these: https://github.com/SunshineStream/Sunshine/blob/master/CMakeLists.txt#L466-L469

@ReenigneArcher ReenigneArcher changed the title install-service.bat and uninstall-service.bat missing v0.14.0 windows package issues Jun 16, 2022
@ReenigneArcher
Copy link
Member

This: https://cmake.org/cmake/help/latest/cpack_gen/nsis.html#variable:CPACK_NSIS_EXTRA_INSTALL_COMMANDS

might allow to install the service automatically. Not sure if it can be used on a single component, so may just need to first check if file exists.

@sitiom sitiom mentioned this issue Jun 17, 2022
Merged
1 task
@ReenigneArcher ReenigneArcher mentioned this issue Jun 17, 2022
Closed
5 tasks
@ReenigneArcher ReenigneArcher mentioned this issue Jul 5, 2022
Closed
This was referenced Aug 10, 2022
Merged
Merged
@ReenigneArcher ReenigneArcher mentioned this issue Aug 22, 2022
Closed
@ReenigneArcher ReenigneArcher mentioned this issue Sep 12, 2022
Merged
5 tasks
@ReenigneArcher ReenigneArcher added the fixed This issue has been fixed and will be available in the next release. label Sep 12, 2022
@github-actions
Copy link

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher marked this as a duplicate of #340 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed This issue has been fixed and will be available in the next release. os:Windows OS is Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.15.0 LizardByte/Sunshine
2 participants
@ReenigneArcher @sitiom