test different coverage path

LizardByte · Apr 21, 2024 · f97414f · f97414f
1 parent 557210e
commit f97414f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -502,6 +502,7 @@ jobs:
         run: |
           ${{ steps.python.outputs.python-path }} -m pip install gcovr
           ${{ steps.python.outputs.python-path }} -m gcovr -r .. \
+            --exclude-noncode-lines \
             --exclude-throw-branches \
             --exclude-unreachable-branches \
             --exclude '.*tests/.*' \
@@ -840,6 +841,7 @@ jobs:
           cd ${build_dir}
           ${{ steps.python.outputs.python-path }} -m pip install gcovr
           sudo ${{ steps.python.outputs.python-path }} -m gcovr -r ../${dir} \
+            --exclude-noncode-lines \
             --exclude-throw-branches \
             --exclude-unreachable-branches \
             --exclude '.*${dir}/tests/.*' \
@@ -1086,6 +1088,7 @@ jobs:
         run: |
           ${{ steps.python-path.outputs.python-path }} -m pip install gcovr
           ${{ steps.python-path.outputs.python-path }} -m gcovr -r .. \
+            --exclude-noncode-lines \
             --exclude-throw-branches \
             --exclude-unreachable-branches \
             --exclude '.*tests/.*' \

diff --git a/src/file_handler.cpp b/src/file_handler.cpp
@@ -31,7 +31,10 @@ namespace file_handler {
     }
 
     std::ifstream in(path);
-    return std::string { (std::istreambuf_iterator<char>(in)), std::istreambuf_iterator<char>() };
+    std::istreambuf_iterator<char> begin(in);
+    std::istreambuf_iterator<char> end;
+    std::string contents(begin, end);
+    return contents;
   }
 
   /**

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -19,8 +19,8 @@ include_directories("${GTEST_SOURCE_DIR}/googletest/include" "${GTEST_SOURCE_DIR
 
 # coverage
 # https://gcovr.com/en/stable/guide/compiling.html#compiler-options
-set(CMAKE_CXX_FLAGS "-fprofile-arcs -ftest-coverage -O1")
-set(CMAKE_C_FLAGS "-fprofile-arcs -ftest-coverage -O1")
+set(CMAKE_CXX_FLAGS "-fprofile-arcs -ftest-coverage -O0")
+set(CMAKE_C_FLAGS "-fprofile-arcs -ftest-coverage -O0")
 
 # if windows
 if (WIN32)