Fix clang warning "private field '...' is not used" #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out unused private class members where never addressed. Declare unused private class members (void) in constructor when only initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several cases in the hal/user_comps/xhc-whb04b-6 pendent code where private member variables are completely unused or initialized and then never used. They generate a warning in clang.
This PR comments out unused private class members where never addressed. The private class members initialized but unused afterwards are declared (void) in the respective constructor.
The other option would be to delete those members completely. However, I cannot tell whether that would have other side effects and is therefore not the path chosen.