Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This device supports Night Display #1

Closed
wants to merge 1 commit into from

Conversation

zacharee
Copy link

  • Tested by manually editing framework-res.apk

 - Tested by manually editing framework-res.apk
@luk1337
Copy link
Member

luk1337 commented Jul 19, 2017

  1. Use Gerrit
  2. We have Live Display this isn't necessary

@zacharee
Copy link
Author

  1. I don't know how to use Gerrit. Could you point me in the right direction?
  2. I have not once been able to get LiveDisplay to work properly. It will automatically fade into night mode once and then stop working completely.

@luk1337
Copy link
Member

luk1337 commented Jul 19, 2017

  1. Check wiki
  2. That's unfortunate but still I am not going to enable something that duplicates what live display is supposed to do.

@zacharee
Copy link
Author

  1. OK. Will do.
  2. This change doesn't add the Night Display option to Settings. It just enables the functionality.

@luk1337
Copy link
Member

luk1337 commented Jul 19, 2017

There's only one device that has this enabled and that's Pixel thus I am not going to accept this change.

@zacharee
Copy link
Author

I don't understand that reasoning, but OK.

@luk1337
Copy link
Member

luk1337 commented Jul 19, 2017

image
As you can see here this isn't widely accepted change as it simply duplicates Live Display functionality.

@zacharee
Copy link
Author

But why not just add it? It isn't like it adds 200MB more to the system image.

@luk1337
Copy link
Member

luk1337 commented Jul 19, 2017

Because we already have Live Display. If you really want this then build your own system images.

@zacharee
Copy link
Author

I'm just decompiling the framework-res.apk. Thought it might be helpful to have.

@lineageos-gerrit
Copy link

Hi there;
This is an automated reply, to let you know LineageOS doesn't merge pull
requests submitted directly to our github.com repositories.

You can submit your change requests through our public review system,
located at https://review.lineageos.org/

That review system is an installation of Google's Gerrit code review.
If you've never interacted with Gerrit before, we also suggest you take
a look at http://wiki.lineageos.org/usinggerrit-howto.html

Thanks!

ripee added a commit to team-infusion-developers/android_device_samsung_gts210vewifi that referenced this pull request Nov 10, 2021
gts210vewifi: proprietary-files: Update default source note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants