Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF_12_PCS #243

Open
wants to merge 242 commits into
base: development
Choose a base branch
from
Open

SF_12_PCS #243

wants to merge 242 commits into from

Conversation

ld-archer
Copy link
Collaborator

@ld-archer ld-archer commented May 17, 2023

Opening this PR for all the work on the SF_12_PCS outcome and pathways leading to it.

At time of opening, the SF_12_PCS module has been created and added to the default.yaml config file. It is running smoothly, and changes have been made to include PCS in outcome visualisations (AGG_VAR is now set in the Makefile so we can use existing code to create plots for both MCS and PCS), and validations in the form of handovers and cross-validation (soon to be renamed/reworked). There is still a lot of work needing to be done, including developing the pathways from start to finish, and doing QALE/QALY calculations using both the MCS and PCS.

DONE:

  • Renamed all previous instances of SF_12 to SF_12_MCS when referring to mental wellbeing
  • Renamed all previous instances of SF_12p to SF_12_PCS when referring to physical wellbeing
  • Created SF_12_PCS module and added to default.yaml and cross_validation.yaml
  • Defined transition model for PCS in model_definitions.txt, and modified estimate_transitions.R to handle both MCS and PCS
  • Included PCS in handovers and cross-validation notebooks
  • Adapted outcome visualisation to allow for both MCS and PCS as outcomes to visualise

To Do:

  • Pathways from start to finish
  • QALE/QALY calculations when PCS pathways complete
  • Further testing/validation?

Also probably part of this:

  • Replace the current phealth proxy from using SF12 questions to instead use GHQ
  • Create an mhealth proxy using GHQ

ld-archer added 5 commits May 16, 2023 11:30
…variable. Also created a PCS module, and tried to modify the outcome visualisation stuff but made some mistakes so still WIP. Handovers work, but cross-validation also still has some issues
…ta in handover plots (assumed that this had been done during complete_case but that was only for some variables). This has changed the shape of the SF12 MCS and PCS plots, and shows some problematic behaviour that needs to be monitored. I believe these will be vastly improved with the rate of change model work that is ongoing, but remains to be seen
…ction combine_and_pivot() to remove all missing values (negative 1-3, 7-9). Also removed some .pngs that were tracked by accident
…argument to make_lineplot.sh in the treated multiplot
@ld-archer ld-archer linked an issue Jul 6, 2023 that may be closed by this pull request
5 tasks
ld-archer and others added 30 commits March 14, 2024 13:51
… generation. also managed to get year adjusted council tax as well.
…population dataframe to make it easier to find important columns. I wrote this function fueled by pure anger and frustration from not having written this function 2 years ago
…responding targets in the QALY.Makefile to analyse them
…tes to utils functions. Notably, have added an argument to the singular datain function to remove zero weight people for handovers. Has a noticeable difference so clearly important
…oups. Also started an R Notebook for the PCS QALY work
…g out of handovers for now as they dont render properly in html notebooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment