-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF_12_PCS #243
Open
ld-archer
wants to merge
242
commits into
development
Choose a base branch
from
231-SF12_PCS
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SF_12_PCS #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable. Also created a PCS module, and tried to modify the outcome visualisation stuff but made some mistakes so still WIP. Handovers work, but cross-validation also still has some issues
…ta in handover plots (assumed that this had been done during complete_case but that was only for some variables). This has changed the shape of the SF12 MCS and PCS plots, and shows some problematic behaviour that needs to be monitored. I believe these will be vastly improved with the rate of change model work that is ongoing, but remains to be seen
…ction combine_and_pivot() to remove all missing values (negative 1-3, 7-9). Also removed some .pngs that were tracked by accident
…argument to make_lineplot.sh in the treated multiplot
… has to be changed in one place
This was
linked to
issues
May 17, 2023
Closed
Closed
…les that probably should have been in some models (things like urban, financial_situation, loneliness etc.)
5 tasks
…g of housing_tenure and fixed typo in handover.Rmd
…_raw.py function, and fixed heating module trying to convert from float to int where it shouldnt have done
…ted the handovers.Rmd script
…em AUDITC score and run through complete case
… script to fit this model
… generation. also managed to get year adjusted council tax as well.
…population dataframe to make it easier to find important columns. I wrote this function fueled by pure anger and frustration from not having written this function 2 years ago
…responding targets in the QALY.Makefile to analyse them
…tes to utils functions. Notably, have added an argument to the singular datain function to remove zero weight people for handovers. Has a noticeable difference so clearly important
…oups. Also started an R Notebook for the PCS QALY work
…g out of handovers for now as they dont render properly in html notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for all the work on the SF_12_PCS outcome and pathways leading to it.
At time of opening, the SF_12_PCS module has been created and added to the default.yaml config file. It is running smoothly, and changes have been made to include PCS in outcome visualisations (AGG_VAR is now set in the Makefile so we can use existing code to create plots for both MCS and PCS), and validations in the form of handovers and cross-validation (soon to be renamed/reworked). There is still a lot of work needing to be done, including developing the pathways from start to finish, and doing QALE/QALY calculations using both the MCS and PCS.
DONE:
To Do:
Also probably part of this: