Add ERC4626 & Kiln DeFi registry #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add generic clear singing for ERC4626 Vaults: - https://eips.ethereum.org/EIPS/eip-4626
…the kiln registry deployments ERC-4626 MUST implement EIP-20 Added the ASSET in the registry to define the ERC-20 used by the user to deposit on the vault.
kilnmg
requested review from
LL782,
pdeville-ledger and
a team
as code owners
There was a problem hiding this comment.
I understand what you are trying to do, but unfortunately it's not possible in the current form:
- constants are restricted to
$.metadata.constants - extra fields in
deploymentsare not allowed - referencing a value "for current deployment" is not possible
I think you can achieve what you want this way:
- in the ERC file, define your display section, using
$.metadata.constants.asset, and other constant stuff such as ABI - then create one calldata file per deployment, it will only contain deployments section + metadata.constants.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ERC4626 in the erc folder:
Todo:
Need to find a better way to make it generic over multiple deployments as of today it's looks like it's always getting :
.deployments.[0]while with ERC4626 DeFi protocols will have a lot of vaults to add in the registry.Added a new registry for Kiln DeFi contracts:
Preview:
Opening a PR for a more advanced review on : http://app.devicesdk.ledger-test.com/