Skip to content

Commit

Permalink
Merge branch 'master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
jnicoulaud-ledger authored Dec 10, 2024
2 parents 1f5c22e + eebfcb9 commit 43b905a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions registry/starkgate/calldata-StarkGate-STRK.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"$id": "deposit",
"intent": "Bridge",
"fields": [
{ "path": "token", "label": "Token", "format": "addressName", "params": { "types": ["token"] } },
{ "path": "amount", "label": "Amount", "format": "amount" },
{ "path": "l2Recipient", "label": "Recipient", "format": "raw" }
{ "path": "amount", "label": "Amount to deposit", "format": "tokenAmount", "params": { "tokenPath": "token" } },
{ "path": "l2Recipient", "label": "Recipient", "format": "raw" },
{ "path": "@.value", "label": "Deposit fee", "format": "amount" }
],
"required": ["token", "amount", "l2Recipient"]
}
Expand Down
14 changes: 7 additions & 7 deletions specs/erc-7730.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ This specification uses a limited [json path](https://www.rfc-editor.org/rfc/rfc
Limitation to the json path specification are the following:
* Paths MUST use the dot notation, including for slice and array selectors (i.e. an element of an array should be selected through `array_name.[index]`)
* Only name, index and slices selectors are supported.
* Slices selectors MUST NOT contain the optional step.
* Slices selectors MUST NOT contain the optional step. Start index is inclusive, end index is exclusive. Start or end index can be omitted to indicate the beginning or end of the array.

In addition, additional *roots* are introduced to support description of paths over multiple files in a single common notation. The root node identifier indicates which document or data location this path references, according to the following table:

Expand All @@ -214,8 +214,8 @@ For paths referring to structured data fields, if a field has a variable length
References to values in the serialized structured data
* `#.params.amountIn` or `params.amountIn` refers to parameter `amountIn` in top-level structure `params` as defined in the ABI
* `#.data.path.[0].path.[-1].to` or `data.path.[0].path.[-1].to` refers to the field `to` taken from last member of `path` array, itself taken from first member of enclosing `path` array, itself part of top level `data` structure.
* `#.params.path.[0:19]` refers to the first 20 bytes of the `path` byte array
* `#.params.path.[-20:-1]` refers to the last 20 bytes of the `path` byte array
* `#.params.path.[:20]` or `#.params.path.[0:20]` refers to the first 20 bytes of the `path` byte array
* `#.params.path.[-20:]` refers to the last 20 bytes of the `path` byte array
* `#.details.[]` refers to the array with the Permit Details of a PermitBatch message

References to values in the format specification file
Expand Down Expand Up @@ -405,7 +405,7 @@ To verify a factory constraints a wallet MUST check that:

**`eip712.schemas`**

The `schemas` key is either an URL pointing to the EIP-712 schemas (in json representation) or an array of individual *EIP-712 json schema*.
The `schemas` key is either an URL pointing to the EIP-712 schemas (in json representation) or an array of either individual *EIP-712 json schema*, or URLs pointing to a single message schema.

An *EIP-712 schema* consists in the subset of the EIP-712 message containing only the `types` and `primaryType` elements of the message, represented in json notation for this specification.

Expand Down Expand Up @@ -800,9 +800,9 @@ A *field format specification* is a json object defining how to format a single

#### Slices in paths

A slice can be applied at the end of paths for dynamic types like bytes, string and arrays.
A slice can be applied at the end of paths.

A slice on a primitive type like bytes and string means that the associated [field format specification](#field-format-specification) MUST only be applied to the corresponding slice of bytes of the underlying data.
A slice on a primitive type like uint256, bytes and string means that the associated [field format specification](#field-format-specification) MUST only be applied to the corresponding slice of bytes of the underlying data.

A slice on an array type means that the associated [field format specification](#field-format-specification) or recursive [structured data format specification](#structured-data-format-specification) MUST be applied to ALL the array elements part of the slice.

Expand All @@ -819,7 +819,7 @@ A slice on an array type means that the associated [field format specification](
"label": "Maximum Amount to Send",
"format": "tokenAmount",
"params": {
"tokenPath": "params.path.[0:19]"
"tokenPath": "params.path.[0:20]"
}
}
]
Expand Down

0 comments on commit 43b905a

Please sign in to comment.