Code

Improvements from code review#313

Code

Merged

bigspider merged 7 commits intodevelopLedgerHQ/app-bitcoin-new:developfrom musig2-fixesLedgerHQ/app-bitcoin-new:musig2-fixesCopy head branch name to clipboardJan 17, 2025

+85-58

Commits

Commits on Jan 10, 2025

• Avoid magic constants whenever possible

  bigspider

  committed
  b2e6270

  Copy full SHA for b2e6270

• musig key aggregation should fail if the resulting point is infinite

  bigspider

  committed
  089edc0

  Copy full SHA for 089edc0

• musig: adherence to specs

  bigspider

  committed
  ddbf49e

  Copy full SHA for ddbf49e

• Add packed attribute for unions; removed unnecessary anonymous struct

  bigspider

  committed
  bae14c8

  Copy full SHA for bae14c8

• Use uint16_t instead of int16_t for indices and thresholds in wallet policy types

  bigspider

  committed
  ebaee09

  Copy full SHA for ebaee09

• musigsession_commit: cleanup, just check for non-zero id instead of the whole struct; improve comment

  bigspider

  committed
  e02379d

  Copy full SHA for e02379d

• Check return value when calling musig_key_agg

  bigspider

  committed
  3a7100e

  Copy full SHA for 3a7100e