Cleanup/roots of unities setup functions #37

anupsv · 2025-01-12T03:35:19Z

Removing 2 functions
Removing unwanted struct fields
Changing tests and bench functions
Addresses: #28

… needed

…tion_form

Co-authored-by: Samuel Laferriere <[email protected]>

tests/kzg_test.rs

src/helpers.rs

src/kzg.rs

benches/bench_kzg_commit.rs

bxue-l2

thanks for cleaning up

benches/bench_kzg_commit.rs

src/kzg.rs

anupsv · 2025-01-14T14:48:53Z

src/kzg.rs

-    /// let max_size = 64;
-    /// let bytes = to_byte_array(&elements, max_size);
-    /// assert_eq!(bytes.len(), 64);
-    /// // bytes will contain up to max_size bytes from the encoded elements


Removed this cause its the wrong example. Also as it's not a public function doctests can't work with it, so I just kept the documentation part since it's useful.

samlaf

LGTM after you remove the is_zero function and fix the ci (think you're prob still using the private calculate_roots_of_unity in some doccomment somewhere?)

anupsv · 2025-01-14T19:03:26Z

calculate_roots_of_unity

Yep, fixed both. Apparently vscode's refactor symbol needs more work on detection.

* adding bare changes for batch verification * adding some comments * adding more comments * moving back to sha2 * removing a test which is no longer needed. Removing methods no longer needed * updates to method visibility, updating tests * fmt fixes * clean up * cleanup, optimization, inline docs * removing unwanted const * more docs and cleanup * formatting * removing unwanted comments * cargo fmt and clippy * adding test for point at infinity * cleaner errors, cleanup * adding another test case * removing unwanted errors * adding fixes per comments * adding 4844 spec references * comment fixes * formatting, adding index out of bound check, removing print statement * removing unwanted test, adding test for evaluate_polynomial_in_evaluation_form * moving test to bottom section * Update src/polynomial.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/helpers.rs Co-authored-by: Samuel Laferriere <[email protected]> * updating deps, and toolchain to 1.84 * removing errors test, no longer useful * adding to_byte_array arg explanation * fmt fixes * fmt and clippy fixes * fixing function names and fmt * clippy fixes * removing unwanted setup functions * removing vars from struct * fixing function name and comments * fixing naming for tests * fixing naming in benches * formatting * removing is_zero --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: Samuel Laferriere

* removing reading g2, fixing g2 tau points. clean up * fixing mainnet points * removing unwated files * style+perf: clean-up and optimize remove_empty_byte_from_padded_bytes_unchecked fn (#41) * style+perf: clean-up and optimize remove_empty_byte_from_padded_bytes_unchecked function * ci: make cargo fmt use nightly There were a bunch of warnings that some of our set fmt properties were not being run: Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel. Warning: can't set `normalize_comments = true`, unstable features are only available in nightly channel. * style: cargo fmt * Revert "ci: make cargo fmt use nightly" Getting "error: toolchain 'nightly-x86_64-unknown-linux-gnu' is not installed" on github, and don't feel like debugging. Not even sure how cargo/rust are installed. Do they come preloaded by default? This reverts commit 6e87e0a. * Revert "style: cargo fmt" This reverts commit ae70bf5. * style: cargo fmt * Cleanup/roots of unities setup functions (#37) * adding bare changes for batch verification * adding some comments * adding more comments * moving back to sha2 * removing a test which is no longer needed. Removing methods no longer needed * updates to method visibility, updating tests * fmt fixes * clean up * cleanup, optimization, inline docs * removing unwanted const * more docs and cleanup * formatting * removing unwanted comments * cargo fmt and clippy * adding test for point at infinity * cleaner errors, cleanup * adding another test case * removing unwanted errors * adding fixes per comments * adding 4844 spec references * comment fixes * formatting, adding index out of bound check, removing print statement * removing unwanted test, adding test for evaluate_polynomial_in_evaluation_form * moving test to bottom section * Update src/polynomial.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/helpers.rs Co-authored-by: Samuel Laferriere <[email protected]> * updating deps, and toolchain to 1.84 * removing errors test, no longer useful * adding to_byte_array arg explanation * fmt fixes * fmt and clippy fixes * fixing function names and fmt * clippy fixes * removing unwanted setup functions * removing vars from struct * fixing function name and comments * fixing naming for tests * fixing naming in benches * formatting * removing is_zero --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: Samuel Laferriere * fixing endianess to big across functions (#39) * fixing endianess to big across functions * removing todo's * storing g2 tau as consts * cargo fmt * moving checker to test, adding explanation, cargo fmt * more cargo fmt --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: Samuel Laferriere <[email protected]>

asv and others added 30 commits January 4, 2025 06:13

adding bare changes for batch verification

55a5bf0

adding some comments

259f6b0

adding more comments

4c4bdd0

moving back to sha2

4ecd566

removing a test which is no longer needed. Removing methods no longer…

cb75b3b

… needed

updates to method visibility, updating tests

42bc913

merging main

f3dd7f4

fmt fixes

02fa7ca

clean up

0807ce0

cleanup, optimization, inline docs

da5e5ad

removing unwanted const

b58174b

more docs and cleanup

c1c2f70

formatting

fa02398

removing unwanted comments

914e059

merging main

c74accf

cargo fmt and clippy

f054c19

adding test for point at infinity

90b3d13

cleaner errors, cleanup

486f7da

adding another test case

32716fe

removing unwanted errors

73bc809

adding fixes per comments

618e098

adding 4844 spec references

f7eb705

comment fixes

61e1744

formatting, adding index out of bound check, removing print statement

1c2a79d

removing unwanted test, adding test for evaluate_polynomial_in_evalua…

baf5a44

…tion_form

moving test to bottom section

aa1ded9

Update src/polynomial.rs

86ceab3

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/kzg.rs

d67adec

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/kzg.rs

02194ba

Co-authored-by: Samuel Laferriere <[email protected]>

Update src/kzg.rs

bfd2fac

Co-authored-by: Samuel Laferriere <[email protected]>

anupsv and others added 11 commits January 10, 2025 12:06

Update src/helpers.rs

1c9bcac

Co-authored-by: Samuel Laferriere <[email protected]>

updating deps, and toolchain to 1.84

f6c07eb

removing errors test, no longer useful

7531098

adding to_byte_array arg explanation

f9bb219

fmt fixes

5f9fa77

fmt and clippy fixes

cdeae7c

fixing function names and fmt

0624dc6

clippy fixes

c6f0bdd

removing unwanted setup functions

47ee092

merge master

1353a69

removing vars from struct

b6f2c2a

anupsv requested review from bxue-l2 and samlaf January 12, 2025 03:36

samlaf reviewed Jan 12, 2025

View reviewed changes

tests/kzg_test.rs Show resolved Hide resolved

src/helpers.rs Outdated Show resolved Hide resolved

src/kzg.rs Outdated Show resolved Hide resolved

benches/bench_kzg_commit.rs Outdated Show resolved Hide resolved

bxue-l2 reviewed Jan 13, 2025

View reviewed changes

benches/bench_kzg_commit.rs Outdated Show resolved Hide resolved

src/kzg.rs Outdated Show resolved Hide resolved

fixing function name and comments

7d350a0

anupsv commented Jan 14, 2025

View reviewed changes

anupsv added 2 commits January 14, 2025 06:49

fixing naming for tests

808b13c

fixing naming in benches

2dc74d2

samlaf approved these changes Jan 14, 2025

View reviewed changes

formatting

785e9a5

anupsv added 2 commits January 14, 2025 11:04

removing is_zero

de18412

Merge branch 'master' into cleanup/roots-of-unities-setup-functions

6086824

anupsv merged commit 8afe7c0 into master Jan 14, 2025
1 check passed

anupsv deleted the cleanup/roots-of-unities-setup-functions branch January 14, 2025 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup/roots of unities setup functions #37

Cleanup/roots of unities setup functions #37

anupsv commented Jan 12, 2025 •

edited

Loading

bxue-l2 left a comment

anupsv Jan 14, 2025

samlaf left a comment

anupsv commented Jan 14, 2025

Cleanup/roots of unities setup functions #37

Cleanup/roots of unities setup functions #37

Conversation

anupsv commented Jan 12, 2025 • edited Loading

bxue-l2 left a comment

Choose a reason for hiding this comment

anupsv Jan 14, 2025

Choose a reason for hiding this comment

samlaf left a comment

Choose a reason for hiding this comment

anupsv commented Jan 14, 2025

anupsv commented Jan 12, 2025 •

edited

Loading