bump to maili #23
Merged
bump to maili #23
+461
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Jan 11, 2025
bin/client/justfile
Outdated
| @@ -69,7 +69,7 @@ run-client-native-against-devnet verbosity='' block_number='' rollup_config_path | |||
| L1_BEACON_RPC="http://127.0.0.1:5052" | |||
| L2_RPC="http://127.0.0.1:9545" | |||
| ROLLUP_NODE_RPC="http://127.0.0.1:7545" | |||
| ROLLUP_CONFIG_PATH="{{justfile_directory()}}/../../optimism/.devnet/rollup.json" | |||
| ROLLUP_CONFIG_PATH="/home/ubuntu/op-main-repo/.devnet/rollup.json" | |||
There was a problem hiding this comment.
why are you reverting to a path that only works on your machine? did the relative one not work?
There was a problem hiding this comment.
nah, just my local thing, will revert this line
|
upgrade to maili would work, unless then hokulea won't compile But I am fine to just find a version that works with op-succint or kailua |
samlaf
approved these changes
Jan 13, 2025
Comment on lines
+86
to
+87
| serde = { version = "1.0.217", default-features = false } | ||
| serde_json = { version = "1.0.135", default-features = false } |
There was a problem hiding this comment.
Suggested change
| serde = { version = "1.0.217", default-features = false } | |
| serde_json = { version = "1.0.135", default-features = false } | |
| serde = { version = "1.0", default-features = false } | |
| serde_json = { version = "1.0", default-features = false } |
There was a problem hiding this comment.
if we don't absolutely need those minimum versions, then don't specify them. makes it easier to get into dependency hell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to maili