feat: can read eigenda v1 cert #17
Conversation
| // the fourth because 0x01010000 in the beginnin is metadata | ||
| match BlobInfo::decode(&mut &item_slice[4..]) { | ||
| Ok(cert_blob_info) => info!("cert_blob_info {:?}", cert_blob_info), | ||
| Err(e) => info!("cannot decode cert_blob_info {:?}", e), |
There was a problem hiding this comment.
return an error instead of logging like this?
There was a problem hiding this comment.
Actually, the main reason to do it, is such that you can still run with optimism da-server. And that won't break.
After this PR, we should always use eigenda-proxy
I can work on error cleanup in the above PR
There was a problem hiding this comment.
sgtm. just add a TODO comment here so that we don't forget.
There was a problem hiding this comment.
or is the plan to not ever merge this PR? In this case let's just close it?
| use alloy_primitives::Bytes; | ||
| use alloy_rlp::{RlpDecodable, RlpEncodable}; | ||
|
|
||
| use alloc::vec::Vec; | ||
|
|
||
| #[derive(Debug, PartialEq, Clone, RlpEncodable, RlpDecodable)] | ||
| pub struct G1Commitment { | ||
| pub x: [u8; 32], | ||
| pub y: [u8; 32], | ||
| } | ||
|
|
||
| #[derive(Debug, PartialEq, Clone, RlpEncodable, RlpDecodable)] | ||
| pub struct BlobQuorumParam { | ||
| pub quorum_number: u32, | ||
| pub adversary_threshold_percentage: u32, |
There was a problem hiding this comment.
We prob want to auto generate these using https://docs.rs/prost-build/latest/prost_build/
There was a problem hiding this comment.
It is a good idea. But prost probably can't work.
Remember we discuss bytes should not go to Vec, otherwise, rlp isn't compatible.
That is why, I imported alloy_primitives::Bytes, it will have the right rlp encoding behavior.
prost converts bytes to Vec, see https://github.com/tokio-rs/prost?tab=readme-ov-file#fields.
We can create an issue
There was a problem hiding this comment.
You can customize the type that prost generates. For eg a build.rs with
use prost_build::Config;
use std::io::Result;
fn main() -> Result<()> {
let mut config = Config::new();
config.bytes(&["."]);
config.compile_protos(&["src/scratch.proto"], &["src/"])?;
Ok(())
}
will generate
#[prost(bytes = "bytes", tag = "3")]
pub batch_root: ::prost::bytes::Bytes,
This uses the prost Bytes type instead of the alloy. I'm sure there's a way to generate the alloy one, but it might require some fiddling around. Let's at least add a TODO comment to eventually switch to using prost.
| @@ -136,6 +138,14 @@ where | |||
| trace!(target: "fetcher_with_eigenda_support", "Fetching hint: {hint_type} {hint_data}"); | |||
|
|
|||
| if hint_type == ExtendedHintType::EigenDACommitment { | |||
| let item_slice = hint_data.as_ref(); | |||
|
|
|||
| // the fourth because 0x01010000 in the beginnin is metadata | |||
There was a problem hiding this comment.
typo: beginnin -> beginning
There was a problem hiding this comment.
close here, 781000e
This is PR add data struct for EigenDA v1 cert, and is able to parse the bytes from EigenDA proxy memstore.