Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slashing #171

Merged
merged 240 commits into from
Jan 22, 2025
Merged

Slashing #171

merged 240 commits into from
Jan 22, 2025

Conversation

TomasArrachea
Copy link
Collaborator

@TomasArrachea TomasArrachea commented Nov 29, 2024 •
edited by MegaRedHand
Loading

Closes #182

TomasArrachea and others added 30 commits November 14, 2024 18:01
@TomasArrachea
add get staker shares method
e64e5de
@TomasArrachea
add get_delegated_operator method
7f4378f
@TomasArrachea
change eigen middleware submodule to slashing branch
caca28e
@TomasArrachea
upload updated bindings
f4afa71
update middleware rev
eb006a0
@TomasArrachea
working bindings
e513be2
@TomasArrachea
restore deleted bindings
d4c0a26
@TomasArrachea
update get_staker_shares method
37696a4
@TomasArrachea
remove deprecated methods and update ElChainReader attributes
fb4babf
@TomasArrachea
add mockavsservicemanager binding
8b348dc
@TomasArrachea
update ElContract Reader tests
cac51e8
wip scripts
c9ef2a4
port scripts from incredible squaring
177ed4c
@TomasArrachea
update elcontracts writer
349b40d
@TomasArrachea
add elcontracts reader build method
277d61d
@TomasArrachea
add bindings
29afec5
@TomasArrachea
add missing bindings
1903878
@TomasArrachea
fix examples
7fc3b85
@TomasArrachea
cargo fmt
6f1c5ba
@TomasArrachea
remove added bindings
75ccd80
@TomasArrachea
fix bindings lib
4fae355
@TomasArrachea
remove more bindings
70e1e05
wip : scripts
403f027
@TomasArrachea
ignore failing tests due to anvil state not updated
651460e
@TomasArrachea
Merge branch 'main' into slashing_methods
bbd91dc
@TomasArrachea
ignore tests
b48ecce
@TomasArrachea
add get_operators_for_operator_set method
b490ed0
@TomasArrachea
add updated bindings
65db644
wip : state load issue
ceb82ef
@TomasArrachea
remove extra bindings
cccec71
MegaRedHand
MegaRedHand reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some functions from the Go SDK are missing:

  • GetOperatorAVSSplit
  • GetOperatorPISplit
  • SetOperatorAVSSplit
  • SetOperatorPISplit
  • ProcessClaims
  • ForceDeregisterFromOperatorSets
  • NewRemovePermissionTx
  • NewSetPermissionTx
  • NewAcceptAdminTx
  • NewAddPendingAdminTx
  • NewRemoveAdminTx
  • NewRemovePendingAdminTx

Also, some reader functions were implemented on the writer:

  • GetDistributionRootsLength
  • CurrRewardsCalculationEndTimestamp
  • GetCurrentClaimableDistributionRoot
  • GetRootIndexFromHash
  • GetCumulativeClaimed
  • CheckClaim

I will work on this on different PRs to avoid muddying this PR.

@MegaRedHand
refactor: move read functions from ELChainWriter to ELChainReader (…
8bc7d45 
…#191)

This PR moves from the EL writer to the reader, these functions:

- [x] GetDistributionRootsLength
- [x] CurrRewardsCalculationEndTimestamp
- [x] GetCurrentClaimableDistributionRoot
- [x] GetRootIndexFromHash
- [x] GetCumulativeClaimed
- [x] CheckClaim
@MegaRedHand
Copy link
Contributor

@supernovahs I made some changes to this PR before branching. Here's the diff so you can review those:
https://github.com/Layr-Labs/eigensdk-rs/pull/171/files/ffad9a30b9138d8c6657c88055e5e11da1e754dc..098656439a9ac830987993851ecefb5e1467bb2d
(should be less than 150 lines changed)

supernovahs
supernovahs reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@supernovahs supernovahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment regarding remapping

@MegaRedHand
feat: add get and set split functions (#192)
45dfdeb 
This PR adds functions:
- `GetOperatorAVSSplit`
- `GetOperatorPISplit`
- `SetOperatorAVSSplit`
- `SetOperatorPISplit`
@MegaRedHand
Copy link
Contributor

Regarding the missing functions, we found that ForceDeregisterFromOperatorSets is a duplicate of DeregisterFromOperatorSets, so we skipped it and made a PR removing it from the Go SDK (Layr-Labs/eigensdk-go#426).

We also skipped the New____Tx functions, since they don't map easily into Rust and I'm not sure of their purpose.

@MegaRedHand
feat: add process_claims function (#193)
9c88c1c 
This PR adds the missing `process_claims` function to the writer and
tests for both claim functions.
@MegaRedHand MegaRedHand mentioned this pull request Jan 8, 2025
Merged
@MegaRedHand MegaRedHand marked this pull request as ready for review January 9, 2025 14:18
MegaRedHand and others added 3 commits January 13, 2025 10:21
@MegaRedHand
Merge branch 'dev' into slashing
d79b367
@MegaRedHand @TomasArrachea
@pablodeymo @supernovahs
chore: merge dev into slashing, and regenerate bindings (#224)
d11e9f6 
This PR merges changes from `dev` to `slashing`, and regenerates the
bindings with `make bindings` (after removing the old ones).

---------

Co-authored-by: Tomas <[email protected]>
Co-authored-by: Pablo Deymonnaz <[email protected]>
Co-authored-by: supernovahs <[email protected]>
Co-authored-by: supernovahs <[email protected]>
@MegaRedHand
Merge branch 'dev' into slashing
c6860b4
@MegaRedHand MegaRedHand mentioned this pull request Jan 16, 2025
Open
@MegaRedHand MegaRedHand linked an issue Jan 16, 2025 that may be closed by this pull request
Pending methods in ElContract Writer #182
Open
@pablodeymo pablodeymo added the changelog-added [changelog] PR adds a new feature label Jan 20, 2025
supernovahs
supernovahs reviewed Jan 21, 2025
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
supernovahs
supernovahs reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@supernovahs supernovahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small nits

@supernovahs
Copy link
Collaborator

we can merge this for now i think . and make a new PR for more upcoming changes in eigenlayer-middleware/contracts

@pablodeymo pablodeymo merged commit c3b34e6 into dev Jan 22, 2025
3 checks passed
@pablodeymo pablodeymo deleted the slashing branch January 22, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@pablodeymo pablodeymo pablodeymo left review comments

@stevennevins stevennevins stevennevins left review comments

@supernovahs supernovahs supernovahs approved these changes

Assignees
No one assigned
Labels
changelog-added [changelog] PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pending methods in ElContract Writer
5 participants
@TomasArrachea @supernovahs @MegaRedHand @stevennevins @pablodeymo