Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: regen align-environments branch #896

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

feat: regen align-environments branch #896

wants to merge 11 commits into from

Conversation

MinisculeTarantula
Copy link
Collaborator

an attempt to recreate and fix #794

modifications had to be made due to changes to configs etc due to work on Zeus

this also notably excludes deploy scripts for the EIGEN token and TimelockControllers specifically for Holesky, where they were already used

@MinisculeTarantula
feat: regen align-environments branch
e985922 
an attempt to recreate and fix #794

modifications had to be made due to changes to configs etc
due to work on Zeus

this also notably excludes deploy scripts for the EIGEN token and TimelockControllers
specifically for Holesky, where they were already used
@MinisculeTarantula
chore: regen additional changes to config files
e27c26f
@MinisculeTarantula
chore: swap test to use new config, delete old one
2d96d71
@MinisculeTarantula
chore: read deployed (legacy) strategies from configs
cb59ff3 
fixes some broken integration tests on forked mainnet environment
@MinisculeTarantula
chore: update fork test try-catch
2e82149
@MinisculeTarantula
chore: deprecate old, flaky test
6b6f266 
this test continues to cause issues while delivering ~no value.

this commit simply deletes it.
@MinisculeTarantula
feat: parse newly-deployed contracts
706a2a5 
also edit 'config check' script to reflect the (partial) deployment

and add new contracts to config files
@MinisculeTarantula
chore: update script to reflect present deployment state
95830e4
@github-actions GitHub Actions
Copy link 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |85.2%    27|88.9%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |95.0%   179|90.7%  43|    -    0
core/StrategyManager.sol                       |97.6%    83| 100%  24|    -    0
libraries/BeaconChainProofs.sol                | 100%    22| 100%  11|    -    0
libraries/BytesLib.sol                         | 0.0%   156| 0.0%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/EigenPod.sol                              | 100%   123|96.2%  26|    -    0
pods/EigenPodManager.sol                       | 100%    75|92.9%  14|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   4|    -    0
strategies/StrategyBase.sol                    |90.9%    44|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12| 100%   5|    -    0
strategies/StrategyFactory.sol                 | 100%    35| 100%   9|    -    0
token/BackingEigen.sol                         |83.3%    30|69.2%  13|    -    0
token/Eigen.sol                                |45.0%    40|61.5%  13|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|76.7%  1163|77.6% 290|    -    0

@MinisculeTarantula
fix: proper owner for beigenTokenProxyAdmin
d772c94 
this contract should be owned by the beigenExecutorMultisig, not the protocolTimelockController_BEIGEN
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |86.1%    36|88.9%   9|    -    0
core/DelegationManager.sol                     |95.8%   237|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |94.1%   222|90.7%  43|    -    0
core/Slasher.sol                               | 4.5%    22| 4.5%  22|    -    0
core/StrategyManager.sol                       |98.1%   107| 100%  24|    -    0
libraries/BeaconChainProofs.sol                | 100%    33| 100%  11|    -    0
libraries/BytesLib.sol                         | 0.0%   170| 0.0%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     4| 100%   1|    -    0
libraries/Endian.sol                           | 100%     3| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    43| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    64| 0.0%  19|    -    0
permissions/Pausable.sol                       |94.3%    35|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    18| 100%   6|    -    0
pods/EigenPod.sol                              |99.3%   151|96.3%  27|    -    0
pods/EigenPodManager.sol                       |98.9%    89|92.9%  14|    -    0
strategies/EigenStrategy.sol                   | 0.0%    14| 0.0%   4|    -    0
strategies/StrategyBase.sol                    |87.3%    63|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    17| 100%   5|    -    0
strategies/StrategyFactory.sol                 | 100%    44| 100%   9|    -    0
token/BackingEigen.sol                         |79.1%    43|69.2%  13|    -    0
token/Eigen.sol                                |49.1%    53|61.5%  13|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%    10| 0.0%   4|    -    0
================================================================================
                                       Total:|75.8%  1478|72.5% 313|    -    0

@MinisculeTarantula
chore: update config file so test script passes
ba1344a 
this reflects the rewardsV2 upgrade being completed on preprod
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |86.1%    36|88.9%   9|    -    0
core/DelegationManager.sol                     |95.8%   237|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |94.1%   222|90.7%  43|    -    0
core/Slasher.sol                               | 4.5%    22| 4.5%  22|    -    0
core/StrategyManager.sol                       |98.1%   107| 100%  24|    -    0
libraries/BeaconChainProofs.sol                | 100%    33| 100%  11|    -    0
libraries/BytesLib.sol                         | 0.0%   170| 0.0%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     4| 100%   1|    -    0
libraries/Endian.sol                           | 100%     3| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    43| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    64| 0.0%  19|    -    0
permissions/Pausable.sol                       |94.3%    35|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    18| 100%   6|    -    0
pods/EigenPod.sol                              |99.3%   151|96.3%  27|    -    0
pods/EigenPodManager.sol                       |98.9%    89|92.9%  14|    -    0
strategies/EigenStrategy.sol                   | 0.0%    14| 0.0%   4|    -    0
strategies/StrategyBase.sol                    |87.3%    63|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    17| 100%   5|    -    0
strategies/StrategyFactory.sol                 | 100%    44| 100%   9|    -    0
token/BackingEigen.sol                         |79.1%    43|69.2%  13|    -    0
token/Eigen.sol                                |49.1%    53|61.5%  13|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%    10| 0.0%   4|    -    0
================================================================================
                                       Total:|75.8%  1478|72.5% 313|    -    0

@github-actions GitHub Actions
Copy link 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |86.1%    36|88.9%   9|    -    0
core/DelegationManager.sol                     |95.8%   237|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |94.1%   222|90.7%  43|    -    0
core/Slasher.sol                               | 4.5%    22| 4.5%  22|    -    0
core/StrategyManager.sol                       |98.1%   107| 100%  24|    -    0
libraries/BeaconChainProofs.sol                | 100%    33| 100%  11|    -    0
libraries/BytesLib.sol                         | 0.0%   170| 0.0%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     4| 100%   1|    -    0
libraries/Endian.sol                           | 100%     3| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    43| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    64| 0.0%  19|    -    0
permissions/Pausable.sol                       |94.3%    35|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    18| 100%   6|    -    0
pods/EigenPod.sol                              |99.3%   151|96.3%  27|    -    0
pods/EigenPodManager.sol                       |98.9%    89|92.9%  14|    -    0
strategies/EigenStrategy.sol                   | 0.0%    14| 0.0%   4|    -    0
strategies/StrategyBase.sol                    |87.3%    63|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    17| 100%   5|    -    0
strategies/StrategyFactory.sol                 | 100%    44| 100%   9|    -    0
token/BackingEigen.sol                         |79.1%    43|69.2%  13|    -    0
token/Eigen.sol                                |49.1%    53|61.5%  13|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%    10| 0.0%   4|    -    0
================================================================================
                                       Total:|75.8%  1478|72.5% 313|    -    0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsanant gpsanant Awaiting requested review from gpsanant

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MinisculeTarantula