fix: signature utils #1015
fix: signature utils #1015
Conversation
Oops, forgot that. Will do. |
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This should be handled via Zeus, we should coordinate with Justin to add this as a parameter that the deploy scripts can use
| @@ -139,4 +139,8 @@ contract AVSDirectory is | |||
| keccak256(abi.encode(OPERATOR_AVS_REGISTRATION_TYPEHASH, operator, avs, salt, expiry)) | |||
| ); | |||
| } | |||
|
|
|||
| function version() public pure override(ISignatureUtils, SignatureUtils) returns (string memory) { | |||
| return "1.0.3"; | |||
There was a problem hiding this comment.
Why not set version as a constructor parameter so Zeus scripts can handle it?
| @@ -1011,4 +1011,8 @@ contract DelegationManager is | |||
| ) | |||
| ); | |||
| } | |||
|
|
|||
| function version() public pure override(ISignatureUtils, SignatureUtils) returns (string memory) { | |||
| return "1.0.3"; | |||
There was a problem hiding this comment.
Per EIP-712 spec, version is simply the major version number (not minor + patch). We should follow this and keep it "1" on all environments.
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md#definition-of-domainseparator
string version the current major version of the signing domain. Signatures from different versions are not compatible.
| @@ -6,6 +6,7 @@ import "@openzeppelin/contracts/token/ERC20/presets/ERC20PresetFixedSupply.sol"; | |||
|
|
|||
| import "src/contracts/core/RewardsCoordinator.sol"; | |||
| import "src/contracts/strategies/StrategyBase.sol"; | |||
| import "src/contracts/mixins/SignatureUtils.sol"; | |||
Changes:
Dynamic Domain Separator:
SignatureUtils.domainSeparator()is now recomputed for each signature verification. This eliminates the need for storing initial values in storage or as immutables, which is important for beacon proxy support.Version Bump Command: Introduced
make bump-version VERSION=2, which automatically updates the version function's return values.