protobuf rename bin record -> period record #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/rename-bin-record
branch
from
1d3d7e8 to
b367b9e
Compare
hopeyen
force-pushed
the
hope/rename-bin-record
branch
from
4c176f8 to
c7c538e
Compare
ian-shim
approved these changes
Jan 9, 2025
api/clients/v2/accountant.go
Outdated
| @@ -43,9 +43,9 @@ func NewAccountant(accountID string, reservation *core.ReservedPayment, onDemand | |||
| //TODO: client storage; currently every instance starts fresh but on-chain or a small store makes more sense | |||
| // Also client is currently responsible for supplying network params, we need to add RPC in order to be automatic | |||
| // There's a subsequent PR that handles populating the accountant with on-chain state from the disperser | |||
There was a problem hiding this comment.
yep. comments removed
cody-littley
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some leftover legacy names
Checks