Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename codeQL-scanning.yaml to codeql-scanning.yaml #1081

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Update and rename codeQL-scanning.yaml to codeql-scanning.yaml #1081

merged 1 commit into from
Jan 8, 2025

Conversation

anupsv
Copy link
Contributor

@anupsv anupsv commented Jan 8, 2025

Why are these changes needed?

Removing paths-ignore param as either paths or paths-ignore can exist but not both.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@anupsv anupsv requested review from jianoaix and ian-shim January 8, 2025 10:39
@anupsv anupsv merged commit f61fa64 into master Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anupsv @jianoaix