Add metrics to encoder v2 #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
approved these changes
Jan 8, 2025
disperser/encoder/server_v2.go
Outdated
| close func() | ||
|
|
||
| runningRequests chan struct{} | ||
| requestPool chan struct{} | ||
| requestPool chan blobRequest |
There was a problem hiding this comment.
nit: can we rename "pool" to "queue" (e.g. queueingRequests, and ServerConfig.RequestQueueSize) so it's consistent with the rest parts?
There was a problem hiding this comment.
Done V2 code will use new request queue flag. Leaving the V1 server code as is though to prevent having to update the config values.
jianoaix
approved these changes
Jan 8, 2025
dmanc
force-pushed
the
encoder-v2-metrics
branch
from
c279b84 to
5c571ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Brings metrics changes made from V1 encoder to V2 encoder. In order to support certain metrics from V1 we need to send the blob size as part of the request.
Checks