-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disperser auth innabox #1052
Merged
cody-littley
merged 108 commits into
Layr-Labs:master
from
cody-littley:disperser-auth-innabox
Jan 10, 2025
Merged
Disperser auth innabox #1052
Changes from all commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
0936f5f
Enable TLS connections between the disperser and the DA nodes.
cody-littley d36424e
Incremental progress.
cody-littley 342d500
Moar cowsay
cody-littley fd2ab69
formatting
cody-littley e2e3fef
Started working on unit test.
cody-littley 4373095
Incremental progress.
cody-littley df38980
It works now, kind of
cody-littley d54c7f7
Incremental progress.
cody-littley 083d67d
Start experimenting with ecdsa.
cody-littley 0a5c91a
Authorize StoreChunks() requests.
cody-littley 8e9c16b
Merge branch 'master' into disperser-auth
cody-littley f348550
Update docs.
cody-littley 01b7ece
Incremental progress.
cody-littley e09a77c
Incremental progress.
cody-littley 290c93c
Incremental progress.
cody-littley 5ba4b7b
Incremental progress.
cody-littley e094371
Added test placeholder.
cody-littley db0885a
shuffle stuff around
cody-littley da2ca6c
Merge branch 'master' into disperser-auth
cody-littley b04fcfa
Unit tests for request signing.
cody-littley 29e7e7d
Delete stale code.
cody-littley fb1ebfb
Get things kind of working
cody-littley 6ca7c9b
Finished unit tests.
cody-littley 3348883
Cleanup.
cody-littley e5966f0
Cleanup
cody-littley f28a5d4
Merge branch 'master' into disperser-auth
cody-littley f0c6f4e
Cleanup.
cody-littley 6a00256
Added request signer.
cody-littley 27d5b8a
Incremental progress.
cody-littley bbd82ec
Update flags.
cody-littley 157c2ea
Started work on unit test, not yet working.
cody-littley d793501
Incremental progress in kludging something together
cody-littley b81e430
Incremental test iteration.
cody-littley 7327db1
Added debug printing.
cody-littley 8cfa971
IT'S ALIVE!
cody-littley 306746e
Partial cleanup.
cody-littley b41d729
Move code to proper locations.
cody-littley d709520
Copy eigensdk-go implementation of kms parsing.
cody-littley 2e44b02
Update kms.go
anupsv aebda81
Create kms_fuzz_test.go
anupsv 260bf79
Update Makefile for fuzz tests
anupsv dbd0d24
Merge pull request #1 from anupsv/disperser-auth
cody-littley 5dbb178
Merge branch 'master' into disperser-auth
cody-littley dcd3e06
Disable request signing if KMS key name is not provided.
cody-littley 11cf45a
Merge branch 'master' into disperser-auth
cody-littley 3580bed
Merge branch 'master' into disperser-auth
cody-littley f6b008f
Tie into bindings.
cody-littley 1493ded
Incremental progress.
cody-littley feab7a1
Merge branch 'master' into disperser-auth
cody-littley 52f2354
Add debug code.
cody-littley 7c5cc93
Fix unit test.
cody-littley c83db79
Disable request signing for inabox e2e test.
cody-littley e5cb69c
Added flag for disabling signing.
cody-littley 20216c4
Cleanup.
cody-littley 3c325ef
Made suggested changes.
cody-littley d4b7051
Start messing around with external KMS keys.
cody-littley 02ed38a
tweak docker build
cody-littley 60ad5c9
Merge branch 'disperser-auth' into disperser-auth-innabox
cody-littley 8560b8b
Remove test.
cody-littley 613bd20
Generate kms key pair.
cody-littley 4912547
Fix localstack url
cody-littley 80c7e6d
Make requested changes.
cody-littley 2b6cbb2
Made suggested changes.
cody-littley a9155a0
Merge branch 'master' into disperser-auth
cody-littley 3a9792c
Merge branch 'disperser-auth' into disperser-auth-innabox
cody-littley a57140c
Add debug stack trace.
cody-littley 11e2ffa
Tweak stack trace.
cody-littley ad89396
Tweak aws URL
cody-littley a2b602e
Manually start localstack.
cody-littley db018f0
Don't start localstack for churner test.
cody-littley d1ac4a8
Skip key generation when localstack is not running.
cody-littley 822ab3d
Write code that sets disperser address.
cody-littley ee262bc
Enable StoreChunks() signing
cody-littley 262e1a9
Change where the disperser address is written to contract.
cody-littley d32d0a8
Wait for disperser address transaction to be handled.
cody-littley 1f42f9d
Actually submit transaction.
cody-littley 7caac2c
Create a block every second.
cody-littley 20fd4da
Use client with no confirmations.
cody-littley b09a43e
Revert anvil change
cody-littley 6f9e242
Change where disperser address is updated.
cody-littley 0a3e35b
Add stack trace.
cody-littley d92252d
Increase stack trace size.
cody-littley 524b22a
Tweak stack trace.
cody-littley 7971b13
Multiple log statements.
cody-littley e07b734
Update disperser address earlier.
cody-littley 8452d09
Initiate logger earlier.
cody-littley 987b26c
Made suggested change.
cody-littley 525e37f
Reshuffle code.
cody-littley 87a7610
Tweaks.
cody-littley 3852dc7
Play with ordering.
cody-littley a305e93
Relocate code.
cody-littley 568e971
Try moving disperser setup again.
cody-littley c77e596
move code
cody-littley 7371497
Tweaks
cody-littley eca25b9
Use other eth client.
cody-littley 26ec866
Made suggested changes.
cody-littley 76efb7a
Lint
cody-littley afe242f
Debug log
cody-littley 4419be1
Enable store chunks request signing.
cody-littley 09b14ce
Generate key prior to writing env files.
cody-littley cd1bfc6
Merge branch 'master' into disperser-auth
cody-littley 35caefb
Merge branch 'disperser-auth' into disperser-auth-innabox
cody-littley 7355080
Fix merge conflict.
cody-littley 6abb354
Merge branch 'master' into disperser-auth-innabox
cody-littley 6003a89
Cleanup
cody-littley 8cbdd60
Made suggested change
cody-littley cba0358
Made suggested changes.
cody-littley 57abb29
Fix test issue
cody-littley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to wait for txn to be mined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a retry loop in the function that calls this function. It will now wait for up to a minute if the disperser address is not available on chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would
EstimateGasPriceAndLimitAndSendTx
in the ethclient work cleaner?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused errors. I initially tried to use this method, but later in the test run I'd get failures with the following error message:
I spent a lot of time on this and was never able to determine how these two things were related. But as soon as I switched to using
SendTransaction
, the problem went away.