Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJS: Prevent extensions of TypedArray exotic objects #2646

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

trflynn89
Copy link
Contributor

This is a normative change in the ECMA-262 spec. See:
tc39/ecma262@c1040ff

This will actually cause a test262 failure:

test/built-ins/Object/freeze/typedarray-backed-by-resizable-buffer.js ✅ -> ❌

But there is an open PR to update that test already:
tc39/test262#4324

This is a normative change in the ECMA-262 spec. See:
tc39/ecma262@c1040ff
Copy link
Contributor

@shannonbooth shannonbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, dang I was almost done with this very same PR

@awesomekling awesomekling merged commit 53a5073 into LadybirdBrowser:master Nov 30, 2024
6 checks passed
@trflynn89 trflynn89 deleted the ta_extensions branch December 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants