Fix build issue when using Mingw-w64 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means alloca.h is no longer required
|
I also had this issue using MSYS2 with mingw-w64 to build rottexpr |
Calinou
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w_wad.cincludes<alloca.h>in order to use thealloca()function. This header does not exist when compiling using Mingw-w64 on my machine, causing a build error. Instead,alloca()is available throughstdlib.h, which includesmalloc.h.This patch replaces the
alloca()call withmalloc()/free(), which removes the need for the header file altogether and also removes the potential for a stack overflow.The README says MinGW was used to build the release; I'm curious why this issue didn't arise then too.