-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macro for consistent sunrealtype formatting #517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven-Roberts
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
June 21, 2024 00:46
gardner48
requested changes
Jun 28, 2024
test/unit_tests/arkode/CXX_serial/ark_test_dahlquist_mri_-1.out
Outdated
Show resolved
Hide resolved
Co-authored-by: David Gardner <[email protected]>
Co-authored-by: David Gardner <[email protected]>
…feature/real-format3
gardner48
reviewed
Jun 29, 2024
gardner48
reviewed
Jun 30, 2024
gardner48
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor items otherwise this looks good
gardner48
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think all that's left before merging is to open a PR in the answers repo
gardner48
added a commit
to sundials-codes/answers
that referenced
this pull request
Jan 15, 2025
Update answers for formatting macros in LLNL/sundials#517 ----- Co-authored-by: David J. Gardner <[email protected]>
gardner48
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #498 after v7.1.0 update