Merge branch 'develop' into docs/reorg-install-guide

.github/workflows/build-ci-containers-e4s.yml

@@ -26,7 +26,7 @@ jobs:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
     - name: Build and push Docker images
-      uses: docker/build-push-action@v6.10.0
+      uses: docker/build-push-action@v6.11.0
       with:
           context: "./docker/sundials-ci/e4s-base"
           build-args: e4s_version=22.05
@@ -56,7 +56,7 @@ jobs:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
     - name: Build and push Docker images
-      uses: docker/build-push-action@v6.10.0
+      uses: docker/build-push-action@v6.11.0
       with:
           context: "./docker/sundials-ci/e4s-quarterly"
           build-args: spack_yaml=./int${{ matrix.indexsize }}-${{ matrix.precision }}/spack.yaml

.github/workflows/build-ci-containers-nightly.yml

@@ -32,7 +32,7 @@ jobs:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
     - name: Build and push Docker images
-      uses: docker/build-push-action@v6.10.0
+      uses: docker/build-push-action@v6.11.0
       with:
           context: "./docker/sundials-ci/spack-nightly"
           build-args: spack_yaml=./int${{ matrix.indexsize }}-${{ matrix.precision }}/spack.yaml

CHANGELOG.md

@@ -8,6 +8,10 @@
 
 ### Bug Fixes
 
+Fixed the behavior of `SUNDIALS_ENABLE_ERROR_CHECKS` so additional runtime error
+checks are disabled by default with all release build types. Previously,
+`MinSizeRel` builds enabled additional error checking by default.
+
 Fixed bug in the ARKODE SPRKStep `SPRKStepReInit` function and `ARKodeReset` function
 with SPRKStep that could cause a segmentation fault when compensated summation is not
 used.

cmake/SundialsBuildOptionsPre.cmake

@@ -76,10 +76,10 @@ endif()
 # Option to enable/disable error checking
 # ---------------------------------------------------------------
 
-if(CMAKE_BUILD_TYPE MATCHES "Release|RelWithDebInfo")
-  set(_default_err_checks OFF)
-else()
+if(CMAKE_BUILD_TYPE MATCHES "Debug")
   set(_default_err_checks ON)
+else()
+  set(_default_err_checks OFF)
 endif()
 
 set(DOCSTR

doc/shared/RecentChanges.rst

@@ -4,6 +4,10 @@
 
 **Bug Fixes**
 
+Fixed the behavior of :cmakeop:`SUNDIALS_ENABLE_ERROR_CHECKS` so additional
+runtime error checks are disabled by default with all release build types.
+Previously, ``MinSizeRel`` builds enabled additional error checking by default.
+
 Fixed bug in the ARKODE SPRKStep :c:func:`SPRKStepReInit` function and
 :c:func:`ARKodeReset` function with SPRKStep that could cause a segmentation
 fault when compensated summation is not used.