Refactor/distributed-tests #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull changes from develop
doutriaux1
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Thanks @bgunnar5 looks good. Just a few comments here and there.
|
for logging purposes: @doutriaux1 messaged approval to merge over teams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the distributed tests from the integration test suite to pytest. It's introducing the start of a new architecture for integration tests where test definitions are spread out over multiple files, as is typical with pytest.
In this PR, we remove the "distributed tests" from github actions, add in "integration tests", and move "unit tests" to it's own action separate from "local tests".
This PR is necessary for existing tests to pass for #489.