-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit testing for Slic ranks and rank counts #1431
Conversation
… all the ranks from [0, nranks) have printed the message
4c734c1
to
41e5ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only thought I have is that it may make the slic tests easier to understand if there were comments in the code indicating why the integer constants are chosen as they are; e.g., why N
in something like (__LINE__ - N)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bmhan12 -- please don't forget to update the RELEASE_NOTES
This PR:
slic_macros_parallel
unit tests.std::ends
fromSLIC_ASSERT
/SLIC_ASSERT_MSG
/SLIC_CHECK
/SLIC_CHECK_MSG
macros that prevented Lumberjack from combining messages. When packing/unpacking messages for combining,std::ends
does not play nice in std::string --> C-style string conversions. Trailingstd::ends
null character does not get included in the conversion, so output/rank Node's message (withstd::ends
null character) will always be different from the other nodes (nostd::ends
null character), and as such no combining would take place.Relates to #1410