removeFile() Usage

[bmhan12]

This PR:

• Fixes removeFile failure on Windows in slic_macros.cpp unit test by closing the files associated with ifstream and the ofstream member variables of LogStream instances.
• Checks the result of removeFile in unit tests to verify file has been deleted

Closes issue #1415

[agcapps]

Unless there's a reason non-Windows should not finalize(), let's please remove the guard on WIN32 here and in the slic_macros_parallel.cpp test. If there is a reason to test removeFile() on non-finaliz()ed slic on non-Windows platforms, I would appreciate knowing.

[bmhan12]

Guard removed! finalize() call will work on Windows and non-Windows systems, guard was a relic of my testing.

[agcapps]

@bmhan12 , thank you for your attention to detail on this.

[kennyweiss]

Thanks @bmhan12 !

[kennyweiss]

What is 440 here? Is it a line number?
It might make sense to add a comment about this for future maintenance of these tests.

[bmhan12]

What is 440 here? Is it a line number?

Yes. In a follow-up PR related to #1410, I'll be updating these line numbers to be like slic_macros_parallel to be __LINE__ - offset to make that clear.

[kennyweiss]

@bmhan12 -- could you please update the documentation for removeFile about it not working on Windows when there are open file handles?

See:

axom/src/axom/core/utilities/FileUtilities.hpp

Lines 86 to 92 in 24751dd

	/*!
	* \brief Remove the specified file.
	* \param filename The name of the file.
	* \return 0 on success, -1 on failure. errno can obtain more information
	* about the failure.
	*/
	int removeFile(const std::string& filename);