Get the Total Amount of Umpire Memory Allocated #929
Conversation
| auto& rm = umpire::ResourceManager::getInstance(); | ||
| std::size_t total_memory{0}; | ||
|
|
||
| for (auto s : rm.getResourceNames()) { |
There was a problem hiding this comment.
Is this limited to the base resources (PINNED, UNIFIED_MEMORY, DEVICE, HOST, etc...)? Or does it include the pools built on top of them? Just want to make sure we're not double counting.
There was a problem hiding this comment.
Just resources - this is the correct way to get everything (including any alignment adjustments) without double counting.
…into feature/get-total-mem-usage
| @@ -328,6 +328,7 @@ class ResourceManager { | |||
| util::AllocationMap m_allocations; | |||
|
|
|||
| std::list<std::unique_ptr<strategy::AllocationStrategy>> m_allocators; | |||
| std::vector<std::string> m_shared_allocators_by_name; | |||
There was a problem hiding this comment.
| std::vector<std::string> m_shared_allocators_by_name; | |
| std::vector<std::string> m_shared_allocator_names; |
The by_name suggests it's a structure to access the allocators by their names (like a map). This isn't the case, so I suggest a slightly different name.
| @@ -347,6 +348,7 @@ class ResourceManager { | |||
| friend std::vector<util::AllocationRecord> get_allocator_records(Allocator); | |||
| friend strategy::ZeroByteHandler; | |||
| friend strategy::mixins::AllocateNull; | |||
| friend std::size_t get_total_memory_allocated(); | |||
There was a problem hiding this comment.
Add a method to the get the names, rather than having this be a friend and accessing the data structure directly
| auto& rm = umpire::ResourceManager::getInstance(); | ||
| std::size_t total_memory{0}; | ||
|
|
||
| for (auto s : rm.getResourceNames()) { |
There was a problem hiding this comment.
Just resources - this is the correct way to get everything (including any alignment adjustments) without double counting.
No description provided.