fix(wheel): don't distribute top-level LICENSE file #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file lands in `lib/python3.11/site-packages/LICENSE` which is too generic. The package info folder already has its license there. No need to re-include it. If not fixed, it collides with the same file provided by i.e. corallium. See KyleKing/corallium#7 for that matter. @moduon MT-1075
|
Thanks! I think I copied that from somewhere years ago and didn't realize the implications. I'll make releases with the "include" attribute patched today! Update: I've released |
KyleKing
approved these changes
Jul 5, 2024
KyleKing
added a commit
to KyleKing/calcipy
that referenced
this pull request
Jul 5, 2024
KyleKing
added a commit
to KyleKing/calcipy_template
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file lands in
lib/python3.11/site-packages/LICENSEwhich is too generic. The package info folder already has its license there. No need to re-include it.If not fixed, it collides with the same file provided by i.e. corallium. See KyleKing/corallium#7 for that matter.
@moduon MT-1075