Put back HILDE_MM stuff after merge. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kyle-B , here you go! |
Kyle-B
pushed a commit
that referenced
this pull request
Aug 19, 2015
The condition to replace = with PRIM_MOVE no longer fires because we are doing insertReferenceTemps before this code is run, and we did not in the past. The fix is to track symbols storing addr_of the ret argument. Two options for better fixes: - delay the insertion of reference temps until later in the program translation. - rework normalization for iterators so that there is no need to localize iterator symbols (possibly following Note #1 at the end of lowerIterators.cpp).
Kyle-B
pushed a commit
that referenced
this pull request
Aug 19, 2015
Fix localizeReturnSymbols to handle = with ref LHS The condition to replace = with PRIM_MOVE no longer fires because we are doing insertReferenceTemps before this code is run, and we did not in the past. The fix is to track symbols storing addr_of the ret argument. Two options for better fixes: - delay the insertion of reference temps until later in the program translation. - rework normalization for iterators so that there is no need to localize iterator symbols (possibly following Note #1 at the end of lowerIterators.cpp).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.